Trap began his career in the royal cabinet secretariat in 1834. Over the following years he was promoted through the ranks. Trap had hoped to succeed Frederik Ferdinand Tillisch as royal secretary but was passed over in favour of C. Liebenberg,
Countess Danner's personal legal advisor, when Tillisch was appointed as new Minister of Interior Affairs in the
Cabinet of Ørsted in April 1854, Trap was installed as acting royal secretary when Liebenberg had to resign in 1756 and was permanently appointed in 1967. Over the past 25 years, Trap had at this point served under seven royal cabinet secretaries. He remained in the job until his retirement February 1884. Trap's work resulted in a lot of travel activity, In 1840, he escorted
Christian VIII and Caroline Amalie on their three months journey around the country. Under
Frederick VII the excursions became more frequent. The king was interested in archeology and participated in a number of excavations. Trap was present at
Frederiksborg Castle on 17 December 1850, when it was destroyed by fire. He was involved in the rescue of around 300 paintings and other historic artifacts. He was also involved in the efforts to rebuilding the castle. Trap was also present at Glücksborg Castle when the king died on 15 November 1863. ==Other occupations==