Potter began his career at
Celtic, but failed to make a senior appearance for them. Potter was highly rated at
Celtic Park and captained the reserve side, most notably on 16 February 1999, when
Mark Viduka made his first appearance in a Celtic shirt in a 4–2 victory against
Motherwell. Potter travelled to
Portugal with the first team squad and was an unused substitute in
Wim Jansen's final game in charge against
Sporting Lisbon, but a change in management from Jansen to
Josef Venglos signalled the end of Potter's career at the club. After leaving Celtic, Potter joined hometown team
Dunfermline Athletic and spent three years at
East End Park. In 2002, he joined
Clyde. He made his debut on the same day he joined Clyde, in an evening fixture against
Partick Thistle. At the beginning of the 2004–05 season, Potter was appointed
captain of Clyde, and started every single game for the Bully Wee that season. He joined
St Mirren in July 2005 and won promotion to the
Scottish Premier League in his first season. He also played as St Mirren won the
2005 Scottish Challenge Cup Final against
Hamilton Academical. At the beginning of the 2008–09 campaign, Saint's manager
Gus MacPherson named Potter as captain, a position he held for three seasons. However, towards the end of the 2010–11 season, Potter - along with 9 other players at St Mirren - was told that his contract would not be renewed and he would be allowed to leave the club on a free transfer. After seeing out his contract at St Mirren, Potter joined his former St Mirren teammate
Paul Gallacher at Dunfermline Athletic, beginning his second spell at the club. He became U20s player/coach assisted by
Craig Dargo in 2012. ==Coaching career==