Leeds Rhinos McShane signed a five-year contract with Leeds in July 2008, keeping him at the club until at least 2013. in 2009 He made his first team debut on the opening day of the 2009 Super League season against
Crusaders at
Headingley. He made two further appearances in 2009, including his first start against
Warrington Wolves. In 2013, McShane made 23 appearances for Leeds. However, at the end of the season,
Leeds agreed to release McShane from his contract and placed him on the transfer list.
Hull F.C. (loan) In April 2010, McShane signed for
Hull F.C. on a one-month loan deal. He made 4 appearances for the club.
Widnes Vikings (loan) In May 2012, Widnes Vikings signed McShane on a loan deal for the rest of the season. McShane made 11 appearances during this period, scoring 3 tries and kicking 4 goals.
Wakefield Trinity Wildcats McShane was signed by
Wakefield Trinity Wildcats in November 2013.
Castleford Tigers In July 2015, McShane joined
Castleford on a two-and-a-half-year contract as part of a deal that saw
Scott Moore move the other way on loan. He made his club debut against
Hull F.C. in the first game of the Super 8s. McShane was ever-present for
Castleford in the
2016 season, appearing in every game. He was named Castleford Tigers' 3rd Place 2017 Player of the Year. In January 2018, it was announced that McShane had signed a new five-year deal with the Tigers. McShane had an outstanding personal season for Castleford in
2018, branded "unlucky" not to be nominated for the Man of Steel award by two-time winner
Paul Sculthorpe. He dominated the club's end-of-season awards, being recognised as the Fans' Player of the Year, Directors' Player of the Year, Players' Player of the Year, and 1st Place Player of the Year. Despite disruption due to injuries within Castleford's squad and the
COVID-19 pandemic, McShane appeared in every game in
2020. In November, McShane was voted Super League's 2020
Man of Steel – Castleford head coach
Daryl Powell said, "He is one of the best nines in the game bar none and his all-round game is fantastic." He became the first player since 2011 to win the award with his team failing to qualify for the play-offs. On 17 July 2021, he played for Castleford in their
2021 Challenge Cup final loss against
St Helens at
Wembley Stadium. In recognition of his continued outstanding form, McShane was named Directors' Player of the Year and won the Immortals Award, voted for by Castleford legends, at the club's 2021 end-of-season awards. Following the retirement of
Michael Shenton, McShane was named as the new Castleford captain in January 2022. He made 28 appearances throughout the season, missing just one game through suspension. He made 14 appearances in total, also kicking eight goals. McShane was awarded a testimonial year for the
2024 season. Castleford faced the
Huddersfield Giants for his
testimonial match on 4 February. Shortly before the first round, McShane suffered a hamstring injury which ruled him out for the opening six weeks. After nine months on the sidelines, McShane made his competitive return on 23 March against
Batley in the
Challenge Cup and marked the occasion by scoring a try and two goals. In late May, complications arose regarding his previous arm injury and he underwent surgery to remove the
orthopedic plates. On 5 September, it was announced that McShane would retire from playing full-time at the end of the season, and he received a guard of honour at his final home game.
York Knights On 6 November 2024, it was announced that McShane had signed for the
York Knights in the
RFL Championship on a two-year deal. In addition to his playing duties, he would also join the coaching staff and work alongside
Mark Applegarth. On 7 June 2025, he played in York's
1895 Cup final victory over
Featherstone. ==International career==