Early career Irving began his playing career in the
North-East of England, appearing for
non-League clubs
Shildon Athletic,
Galashiels United and
Esh Winning. In 1911, he had an unsuccessful trial with
Football League First Division side
Newcastle United before eventually being signed to a
Football League side with
Bristol City in November 1913.
Dundee Irving quickly impressed during the club's pre-season and debuted for the first team on the opening day of the
1920–21 season in a 2–2 draw away at
Falkirk on 16 August. He immediately established himself in the first team and scored his first goal for the side on 4 September in a victory over Falkirk. After receiving the ball, he advanced to the
penalty area before shooting past the opposition goalkeeper, with the
Dundee Evening Telegraph describing it as a "great goal". With the club struggling to fulfill their forward line, Irving moved from his traditional
half back role to play as an
outside right in November, although it was deemed unsuccessful by the
Dundee Courier who noted that his presence was also missed from the half back line. His early season was later disrupted after missing several weeks of the season during the later months of 1920 after sustaining an injury against
Airdrieonians. He made his return in December against
Hamilton Academical. Irving helped the club to a fourth-placed finish in the 1920–21 Scottish Football League. At the end of his debut season with Dundee, Irving was appointed captain of the first team. After failing to win their opening two games of the
1921–22 campaign, Irving led his side to victory over
Third Lanark after which the
Dundee Courier remarked that there was "probably no more popular player" at the club than Irving. These early performances led to him being considered for his first selection for the
Ireland national football team, but he was denied a call up due to injury. These persistent problems would disrupt most of the remaining season as he missed several months at the start of 1922 with injuries, before returning in April. Dundee achieved another fourth-place finish during the season. The following year, Dundee were unable to repeat their top four finishes and fell to seventh place before undertaking a tour of Spain at the end of the campaign. Irving missed the opening of the
1923–24 season due to injury. He returned to the first team in September but suffered further injury problems after playing for Ireland against
England in October that saw him rarely feature in the following months. He returned to the first team in late February 1924 against Third Lanark. However, Irving continued to be plagued by knee problems; he was stretchered off in matches against both
St Mirren on 30 March and
Clydebank on 19 April. Representatives from
Burnley had travelled to watch Irving play in the latter match, the final game of the season, and were informed that the recurring problem would require surgery to remove a piece of loose cartilage from the knee to rectify the problem. Although troubled by injury, Irving was resigned for the following season. However, he began the season as cover for Crawford Letham until the latter was sold to
Cowdenbeath in September. Having overcome his injury concerns, Irving remained a first team regular and returned to form. Although Dundee finished in eighth place in the league, their lowest placing since Irving's arrival, Irving started the
1925–26 season in goalscoring form, opening his account for the campaign on the opening day during a 3–0 win over
Morton. He added another against local rivals
Dundee United a week later, in the first
Dundee derby played since United's promotion to the top tier of Scottish football. Irving's side won the match 5–0 with his goal being scored via a deflected shot off a United player. He was awarded a
benefit match against
Sunderland in April 1926. More than 11,000 people attended the match which raised around £500 for Irving. Dundee ended the season in 10th place. Irving had nearly joined Cardiff in February 1924 but the move had collapsed. He made his debut for Cardiff in a goalless draw with
Leeds United on 30 August, before scoring his first goal on 9 October in a 3–0 win over
Sheffield United. Having initially played at half back, he was moved to inside right in February 1927 and remained there for the rest of the campaign. Irving made 27 league appearances, scoring three times as Cardiff finished in 14th place. He also played in all six of the club's matches en route to reaching the
1927 FA Cup Final and was instrumental in his side's 3–2 victory over
Chelsea in a sixth round
replay, scoring one and assisting
Len Davies for another. In the final, Irving started at inside right as Cardiff went on to beat
Arsenal 1–0 to become the only side from outside England to win the competition. Two weeks later, Irving scored in the final of the
Welsh Cup as Cardiff defeated
Rhyl to complete a cup double. During a 2–1 defeat against Burnley on 24 December, Irving was hit in the chest by a forceful shot. After the match, he was taken ill and rushed to hospital where he was diagnosed with
pleurisy. Irving found his first team opportunities limited after the injury and appeared in only four more matches for the club. Despite his advancing years, the
Dundee Evening Telegraph reported that by December of the same year he was excelling following his move to Chelsea. Near the end of his first full season with Chelsea, Irving was signed on for another season shortly before the club embarked on a 20-match tour of South America. The team were surprised by the unsporting tactics of their opponents, and antics of the crowd who pelted them with oranges. Irving responded by catching one of the oranges, before peeling and eating the fruit. He was part of the side that won promotion out of the Second Division during the
1929–30 season after finishing the campaign as runners-up. During a match against
Liverpool in October 1931, Irving collapsed on the field late in the game and required medical attention. The cause was later discovered to be a burst
varicose vein in his knee. The injury would keep Irving out of the side until the following year and, on his return, he found himself unable to regain his place in the first team. At the end of the
1931–32 season Irving was released by the club.
Bristol Rovers In May 1932, he returned to
Bristol, this time signing for
Bristol Rovers alongside teammate
Alec Donald. Irving assumed a player-coach role upon his arrival at the club. After leaving Rovers at the end of the season, Irving spent a year away from playing. He initially agreed to join Scottish Division Two side
Brechin City in August 1934 but later backed out of the deal after deciding to retire from playing. ==International career==