He was elected to the
Punjab Legislative Assembly in 1977 on an
Akali Dal ticket from
Phillaur for first time. He was re-elected from Phillaur in 1980, 1985, 1997 and 2007. In 2012, he successfully contested from Kartarpur. Presently he is cabinet minister and holding portfolio of Jails, Tourism, Cultural Affairs and Printing and Stationery. He made headlines in 2014 when he resigned from the Cabinet on moral grounds following media reports concerning the alleged involvement of a family member in a drug racket; later, his properties, as well as those of his son, were provisionally attached by the Enforcement Directorate in connection with investigations. In 2016, following disagreements over being denied a ticket, he left SAD and joined the
Indian National Congress, but in 2022, he and his son joined the breakaway
Shiromani Akali Dal (Sanyukt). ==Achievements==