He was educated at the
Academy of Philadelphia, and admitted to the Dauphin County bar in 1791. He volunteered to help suppress the
Whiskey Rebellion but declined commissions until afterwards, when he was made lieutenant colonel. He practiced law for over forty years. He was active in Harrisburg affairs and was notably "the prominent and leading spirit" behind organizing the
Harrisburg Bridge Company, which built (1814-1820) and ran the first
Susquehanna-spanning bridge. He was elected (1816) and re-elected by the directors as the company's first president until he resigned in 1846. He was president of the Harrisburg Bank from 1816 until his death. Elder served as state Attorney General from 1820 to 1823. Afterwards, he always refused political offices although he maintained an interest in politics.
William Henry Harrison's "
log cabin campaign" was a suggestion of Elder. ==Personal life==