After leaving Larkhall Academy, Miller started playing for local side
Royal Albert, where he would stay until 1959. He was signed by
Dunfermline Athletic before the start of the
1959–60 season, instantly becoming a first-team regular as the
Pars battled against relegation. The arrival of
Jock Stein in 1960 transformed the side however, and against the odds they reached the 1961 Scottish Cup final against
Celtic. Miller played as a wing-half in an initial 0–0 draw; however, an injury to Jackie Williamson required him to move to centre-half for the replay. The subsequent 2–0 victory enshrined that XI's place in Dunfermline folklore and served to galvanise the entire club. Dunfermline developed into regular challengers at the top end of the league table and Miller notched seven goals as they finished an unprecedented 4th in
1961–62. The team also enjoyed several notable European campaigns, with Miller's individual highlight coming in the 1962–63
Fairs Cup, his 2nd-leg goal helping the
Pars to a memorable 2–1 aggregate victory over English giants
Everton. Miller was the subject of a lucrative transfer bid from
Wolves in October 1964 and the
£28,500 on offer proved too much for Dunfermline to resist. However, he failed to settle in the
West Midlands and returned to Scotland after just 13 months after 45 appearances, joining league runners-up
Heart of Midlothian in November 1965. He spent three seasons at
Tynecastle, with the highlight being a run to the final of the
1967–68 Scottish Cup final, where his former side Dunfermline defeated the
Maroons 3–1. In November 1968, Miller joined
Falkirk, then struggling near the bottom of the First Division. Despite his best efforts they were relegated but bounced back to claim the
1969–70 Division Two title. By this stage Miller was approaching veteran status and, after two seasons of First Division consolidation with Falkirk, he left
Brockville Park in 1972 to become manager of recently relegated Dunfermline Athletic in the summer of 1972. ==Managerial career==