Fedorchuk was born in
Netishyn,
Khmelnytskyi Oblast,
Ukrainian SSR,
Soviet Union. He began his career in the youth side for
Svitanok Vinnytsia under head coach Sergey Verich, who scored in his first season 25 goals in the Duflo 71 and in 2005 signed his first professional contract for
FC Kryvbas Kryvyi Rih, here earned his first seven professional matches over two years. In January 2007 Fedorchuk left Kryvbas Kryvyi Rih and signed for
FC Lviv who played 29 games, two Cup Matches and scored three goals. On 1 March 2010, he joined
Ukrainian Premier League side
FC Dnipro Dnipropetrovsk for €480,000 transfer fee, but was initially loaned back to Kryvbas. On 4 February 2016, Fedorchuk signed a contract with Ukrainian champions
Dynamo Kyiv until the end of the 2015–16 season, signing as a free agent after his contract with Dnipro Dnipropetrovsk had expired. On 21 August 2020, Fedorchuk signed a contract with Ukrainian club
Rukh Lviv as a free agent after his contract with
Mariupol had expired. Valeriy announced the end of playing career on 13 March 2023 after 296 total appearances in
Ukrainian Premier League. ==International career==